Fix ssr example #18
Merged
Fix ssr example #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScriptedAlchemy
approved these changes
May 4, 2020
newvladimirov
pushed a commit
to newvladimirov/module-federation-examples
that referenced
this pull request
Jul 17, 2020
This plugin removes the need to manually implement `import('bootstrap.js')` in a federated application.
Solves angular/cli blockers around static analysis limitations with dynamic imports.
newvladimirov
pushed a commit
to newvladimirov/module-federation-examples
that referenced
this pull request
Jul 17, 2020
* fix filename for module federation * add interactive example into ssr example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that filename was copy-pasted from src :)
Also, I added small interactivity so we can check that chunks are loaded
I want to add an example with loadable, but seems that it's better to move it into separate PR
UPD: created draft #19 with loadable example